Skip to content

Pipe: rename iotdb-thrift-ssl-sink & allow not specifying connector in kv attrs & support kv attrs that don't have sink. / processor. / sink. prefixes#11715

Merged
SteveYurongSu merged 8 commits intomasterfrom
pipe-ssl-refactor
Dec 14, 2023

Conversation

@SteveYurongSu
Copy link
Copy Markdown
Member

@SteveYurongSu SteveYurongSu commented Dec 14, 2023

Description

  1. iotdb-ssl-sink -> iotdb-thrift-ssl-sink
  2. allow not specifying connector in kv attrs
  3. support kv attrs that dont have sink. processor. sink. prefixes

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (bcc3b3d) 49.08% compared to head (d9ec680) 49.09%.
Report is 6 commits behind head on master.

Files Patch % Lines
...protocol/thrift/sync/IoTDBThriftSyncConnector.java 47.36% 10 Missing ⚠️
...db/confignode/persistence/pipe/PipePluginInfo.java 0.00% 3 Missing ⚠️
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 1 Missing ⚠️
...gin/builtin/connector/IoTDBThriftSslConnector.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11715   +/-   ##
=========================================
  Coverage     49.08%   49.09%           
- Complexity    24999    25003    +4     
=========================================
  Files          2823     2825    +2     
  Lines        176974   177045   +71     
  Branches      21212    21224   +12     
=========================================
+ Hits          86871    86919   +48     
- Misses        90103    90126   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu self-assigned this Dec 14, 2023
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@SteveYurongSu SteveYurongSu changed the title Pipe: iotdb-thrift-ssl-sink & allow not specifying connector in kv attrs & support kv attrs that dont have sink. processor. sink. prefixes Pipe: rename iotdb-thrift-ssl-sink & allow not specifying connector in kv attrs & support kv attrs that don't have sink. / processor. / sink. prefixes Dec 14, 2023
@SteveYurongSu SteveYurongSu merged commit 795d420 into master Dec 14, 2023
@SteveYurongSu SteveYurongSu deleted the pipe-ssl-refactor branch December 14, 2023 10:15
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…n kv attrs & support kv attrs that don't have sink. / processor. / sink. prefixes (apache#11715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants