Pipe: validate the value of extractor.pattern#11720
Merged
SteveYurongSu merged 11 commits intoapache:masterfrom Dec 18, 2023
Merged
Pipe: validate the value of extractor.pattern#11720SteveYurongSu merged 11 commits intoapache:masterfrom
SteveYurongSu merged 11 commits intoapache:masterfrom
Conversation
added 2 commits
December 14, 2023 16:14
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Outdated
Show resolved
Hide resolved
…ractor/IoTDBDataRegionExtractor.java
added 3 commits
December 14, 2023 16:33
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
SteveYurongSu
approved these changes
Dec 14, 2023
Caideyipi
reviewed
Dec 14, 2023
.../datanode/src/test/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractorTest.java
Outdated
Show resolved
Hide resolved
Caideyipi
reviewed
Dec 14, 2023
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Outdated
Show resolved
Hide resolved
.../datanode/src/test/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractorTest.java
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
Show resolved
Hide resolved
SteveYurongSu
approved these changes
Dec 18, 2023
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Steve Yurong Su <rong@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. Now only strings that meet the IoTDB time series path rules can become parameter values for extractor.pattern.

It will throw an exception like this, if the pattern is an illegal path: