Take snapshot for mods using copy instead of hard link#11728
Merged
OneSizeFitsQuorum merged 2 commits intomasterfrom Dec 15, 2023
Merged
Take snapshot for mods using copy instead of hard link#11728OneSizeFitsQuorum merged 2 commits intomasterfrom
OneSizeFitsQuorum merged 2 commits intomasterfrom
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11728 +/- ##
============================================
- Coverage 49.09% 49.09% -0.01%
Complexity 25008 25008
============================================
Files 2827 2827
Lines 177064 177072 +8
Branches 21225 21226 +1
============================================
- Hits 86935 86934 -1
- Misses 90129 90138 +9 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a hard link of mods file is created when taking snapshot for data region, but the mods file is not immutable, which means the snapshot could be updated. We need to make sure the snapshot is immutable too, so a copy of mods file should be created instead of hard link.