Show regionId supports SQL queries by time range.#11747
Merged
CRZbulabula merged 7 commits intoapache:masterfrom Dec 22, 2023
Merged
Show regionId supports SQL queries by time range.#11747CRZbulabula merged 7 commits intoapache:masterfrom
CRZbulabula merged 7 commits intoapache:masterfrom
Conversation
CRZbulabula
requested changes
Dec 19, 2023
Contributor
CRZbulabula
left a comment
CRZbulabula
left a comment
There was a problem hiding this comment.
Awesome work! However, please pay attention to the following details:
- This PR is an improvement to a existed SQL. Therefore, please add function screenshort(through querying with CLI) in the description.
- Please add some corresponding SQL test cases in the ClusterIT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9665, I improved the SQL query for displaying regionId. However, it didn't support SQL queries based on a time range. Now, it supports SQL queries based on a time range.
sql with range time example
you can see more information in https://apache-iotdb.feishu.cn/docx/NnzTdj3RcoSJyjxDSFxc01PJnvY#doxcnXfK9CBQk8fnRF5GpLiiuyh