Load: Fix InstanceAlreadyExistsException caused by concurrent registration on JMXService#11755
Merged
SteveYurongSu merged 1 commit intoapache:masterfrom Dec 20, 2023
Merged
Conversation
SteveYurongSu
approved these changes
Dec 20, 2023
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
…ation on JMXService (apache#11755) Previously, the concurrent call to "registerMBean" or "deregisterMBean" may cause after 2 threads seeing the same state simultaneously, that one thread changes the state and make another one throw InstanceAlreadyExistsException or InstanceNotFoundException. This PR fixed this problem by adding synchronize to the 2 functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the concurrent call to "registerMBean" or "deregisterMBean" may cause after 2 threads seeing the same state simultaneously, that one thread changes the state and make another one throw InstanceAlreadyExistsException or InstanceNotFoundException. This PR fixed this problem by adding synchronize to the 2 functions.
Log example when exception occurs: