Skip to content

DataRegion should return WRITE_PROCESS_REJECT to Consensus when insert rejected#11782

Merged
HTHou merged 1 commit intomasterfrom
return_reject
Dec 25, 2023
Merged

DataRegion should return WRITE_PROCESS_REJECT to Consensus when insert rejected#11782
HTHou merged 1 commit intomasterfrom
return_reject

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented Dec 25, 2023

Description

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
35.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (2f2505c) 49.13% compared to head (b65ecef) 49.13%.
Report is 1 commits behind head on master.

Files Patch % Lines
.../statemachine/dataregion/DataExecutionVisitor.java 0.00% 22 Missing ⚠️
.../iotdb/db/storageengine/dataregion/DataRegion.java 0.00% 2 Missing ⚠️
...tatemachine/dataregion/DataRegionStateMachine.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11782   +/-   ##
=========================================
  Coverage     49.13%   49.13%           
- Complexity    25347    25362   +15     
=========================================
  Files          2890     2890           
  Lines        179166   179185   +19     
  Branches      21408    21412    +4     
=========================================
+ Hits          88025    88048   +23     
+ Misses        91141    91137    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HTHou HTHou merged commit 71a0306 into master Dec 25, 2023
@HTHou HTHou deleted the return_reject branch December 25, 2023 10:26
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants