Skip to content

Pipe: conceal SSL trust store password & improve exception messages for sink connection establishment#11806

Merged
SteveYurongSu merged 7 commits intoapache:masterfrom
VGalaxies:fix-pipe-ssl
Jan 2, 2024
Merged

Pipe: conceal SSL trust store password & improve exception messages for sink connection establishment#11806
SteveYurongSu merged 7 commits intoapache:masterfrom
VGalaxies:fix-pipe-ssl

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

Description

As title, with more details:

  1. Concealing the ssl.trust-store-pwd in parameters.
  2. Implementing stricter checks for SSL in the case of async connector.
  3. Standardizing exceptions thrown during the construction of IoTDBThriftSyncConnectorClient as PipeConnectionException.
  4. Standardizing exceptions thrown during the parsing of node URLs as PipeParameterNotValidException.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-assigned this Dec 29, 2023
@SteveYurongSu SteveYurongSu merged commit dd7bada into apache:master Jan 2, 2024
@VGalaxies VGalaxies deleted the fix-pipe-ssl branch January 3, 2024 02:08
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…or sink connection establishment (apache#11806)

1. Concealing the `ssl.trust-store-pwd` in parameters.
2. Implementing stricter checks for SSL in the case of async connector.
3. Standardizing exceptions thrown during the construction of `IoTDBThriftSyncConnectorClient` as `PipeConnectionException`.
4. Standardizing exceptions thrown during the parsing of node URLs as `PipeParameterNotValidException`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants