Skip to content

fix the error of writing metrics#11846

Merged
HTHou merged 1 commit intomasterfrom
fix_writing_metric
Jan 4, 2024
Merged

fix the error of writing metrics#11846
HTHou merged 1 commit intomasterfrom
fix_writing_metric

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented Jan 4, 2024

Description

The current code contains the following metrics errors, this PR is for fixing them.

2024-01-04 14:27:40,447 [pool-9-IoTDB-StorageEngine-2] ERROR o.a.i.m.utils.MetricInfo:52 - The size of metric tags should be even, but was name,region,2.
2024-01-04 14:27:40,447 [pool-9-IoTDB-StorageEngine-1] ERROR o.a.i.m.utils.MetricInfo:52 - The size of metric tags should be even, but was name,region,1.

img_v3_026j_f4ac57e6-9f73-4b02-aa11-c961b35c66bg

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (7595a1a) 49.01% compared to head (15dd767) 49.02%.
Report is 4 commits behind head on master.

Files Patch % Lines
.../db/storageengine/dataregion/wal/node/WALNode.java 83.92% 9 Missing ⚠️
...pache/iotdb/db/service/metrics/WritingMetrics.java 0.00% 4 Missing ⚠️
...e/dataregion/memtable/AlignedWritableMemChunk.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11846   +/-   ##
=========================================
  Coverage     49.01%   49.02%           
+ Complexity    25586    25583    -3     
=========================================
  Files          2907     2907           
  Lines        181077   181077           
  Branches      21670    21669    -1     
=========================================
+ Hits          88754    88769   +15     
+ Misses        92323    92308   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@SpriCoder SpriCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@HTHou HTHou merged commit 4953d6f into master Jan 4, 2024
@HTHou HTHou deleted the fix_writing_metric branch January 4, 2024 08:56
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants