Skip to content

Pipe: fix constructor of PipeTsFileInsertionEvent & filter out empty events on sender side#11862

Merged
SteveYurongSu merged 8 commits intoapache:masterfrom
VGalaxies:fix-realtime-filter
Jan 9, 2024
Merged

Pipe: fix constructor of PipeTsFileInsertionEvent & filter out empty events on sender side#11862
SteveYurongSu merged 8 commits intoapache:masterfrom
VGalaxies:fix-realtime-filter

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

Description

This PR is a fix and optimization for #11757, including the following:

  1. Fixing the constructor of PipeTsFileInsertionEvent that caused issues with incorrect initialization of event time, and enhancing related integration tests.
  2. Filtering out empty events on the sender side to reduce data traffic, while lowering the log level for parsing empty events to debug.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-assigned this Jan 8, 2024
@SteveYurongSu SteveYurongSu merged commit 4af1bf8 into apache:master Jan 9, 2024
@VGalaxies VGalaxies deleted the fix-realtime-filter branch January 9, 2024 08:22
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants