Fix TsFileResource is deleted cause compaction validation result is not correct#11878
Merged
HTHou merged 7 commits intoapache:masterfrom Jan 15, 2024
Merged
Conversation
caozj1011
approved these changes
Jan 11, 2024
HTHou
approved these changes
Jan 15, 2024
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When validate whether the compaction target file is overlapped with sequence files or not, the resource file may be read by buildDeviceTimeIndex(). However, other sequence files may be deleted by other compaction task. Then the validation method will catch an IOException and directly return a flag which means validate successfully.