Fix wrong calculation of ExchangeNum for consumeAllPipelineBreaker when dop = 1#11894
Merged
JackieTien97 merged 2 commits intomasterfrom Jan 16, 2024
Merged
Fix wrong calculation of ExchangeNum for consumeAllPipelineBreaker when dop = 1#11894JackieTien97 merged 2 commits intomasterfrom
JackieTien97 merged 2 commits intomasterfrom
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11894 +/- ##
============================================
- Coverage 49.02% 48.98% -0.04%
- Complexity 25692 25711 +19
============================================
Files 2909 2910 +1
Lines 181860 182053 +193
Branches 21804 21826 +22
============================================
+ Hits 89154 89184 +30
- Misses 92706 92869 +163 ☔ View full report in Codecov by Sentry. |
JackieTien97
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of incorrectly calculating the ExchangeNum when constructing the pipeline. When the dop is set to 1, we should not override the ExchangeNum of the recursively calculated context with the current context's ExchangeNum.