Change partial aggregation symbols for variance and standard deviation aggregators.#11932
Merged
JackieTien97 merged 5 commits intoapache:masterfrom Jan 19, 2024
Merged
Conversation
JackieTien97
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IoTDB uses
TypeProviderclass to identify type by given symbol. And aggregators have two output types, one for partial output, another for final output.In variance and standard deviation aggregators, the two types are different. The partial output type is
TEXTwhile the final output type depends on user's input, which can beINT,FLOATand so on.However, current implementation outputs same symbols for both partial and final aggregators for variance and standard deviation. And this may cause some unexpected behaviors like the final output type can be overrided by partial output type.
This PR adds
_partialsuffix to partial output symbol in order to distinguish from final output symbol. Notice there is no need to add new integration tests for this scenario, since #11581 already addGROUP BY LEVELin specific test file, whichhas covered this problem.
This PR has: