Skip to content

Change partial aggregation symbols for variance and standard deviation aggregators.#11932

Merged
JackieTien97 merged 5 commits intoapache:masterfrom
Sh-Zh-7:var_stddev_aggregator_fix
Jan 19, 2024
Merged

Change partial aggregation symbols for variance and standard deviation aggregators.#11932
JackieTien97 merged 5 commits intoapache:masterfrom
Sh-Zh-7:var_stddev_aggregator_fix

Conversation

@Sh-Zh-7
Copy link
Copy Markdown
Contributor

@Sh-Zh-7 Sh-Zh-7 commented Jan 18, 2024

Description

IoTDB uses TypeProvider class to identify type by given symbol. And aggregators have two output types, one for partial output, another for final output.

In variance and standard deviation aggregators, the two types are different. The partial output type is TEXT while the final output type depends on user's input, which can be INT, FLOAT and so on.

However, current implementation outputs same symbols for both partial and final aggregators for variance and standard deviation. And this may cause some unexpected behaviors like the final output type can be overrided by partial output type.

This PR adds _partial suffix to partial output symbol in order to distinguish from final output symbol. Notice there is no need to add new integration tests for this scenario, since #11581 already add GROUP BY LEVEL in specific test file, which
has covered this problem.


This PR has:

  • been self-reviewed.
  • been tested in a test IoTDB cluster.

@JackieTien97 JackieTien97 merged commit f94f99a into apache:master Jan 19, 2024
@Sh-Zh-7 Sh-Zh-7 deleted the var_stddev_aggregator_fix branch January 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants