Skip to content

Pipe: Support InsertRows in PipeInsertNodeTabletInsertionEvent#12286

Merged
SteveYurongSu merged 26 commits intoapache:masterfrom
Caideyipi:rows-support
Apr 26, 2024
Merged

Pipe: Support InsertRows in PipeInsertNodeTabletInsertionEvent#12286
SteveYurongSu merged 26 commits intoapache:masterfrom
Caideyipi:rows-support

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Apr 3, 2024

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi marked this pull request as draft April 3, 2024 03:31
@SteveYurongSu SteveYurongSu self-requested a review April 3, 2024 04:14
@SteveYurongSu SteveYurongSu self-assigned this Apr 3, 2024
@Caideyipi Caideyipi marked this pull request as ready for review April 11, 2024 08:42
@SteveYurongSu
Copy link
Member

@HTHou

Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveYurongSu SteveYurongSu merged commit 1b98197 into apache:master Apr 26, 2024
HTHou pushed a commit that referenced this pull request Jun 26, 2024
Co-authored-by: Steve Yurong Su <rong@apache.org>
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants