Subscription: Push consumer & Async commit#12294
Merged
SteveYurongSu merged 10 commits intoapache:masterfrom Apr 19, 2024
Merged
Subscription: Push consumer & Async commit#12294SteveYurongSu merged 10 commits intoapache:masterfrom
SteveYurongSu merged 10 commits intoapache:masterfrom
Conversation
# Conflicts: # iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionConsumer.java # iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionPullConsumer.java # iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionPushConsumer.java
VGalaxies
reviewed
Apr 15, 2024
Comment on lines
+59
to
+60
| public static final int PUSH_CONSUMER_AUTO_POLL_INTERVAL = 1000; | ||
| public static final int PUSH_CONSUMER_AUTO_POLL_TIME_OUT = 2000; |
Contributor
There was a problem hiding this comment.
It's better to add time units in the naming like _MS_.
| @@ -174,7 +179,7 @@ public synchronized void close() throws IoTDBConnectionException { | |||
| shutdownEndpointsSyncer(); | |||
|
|
|||
| // shutdown heartbeat worker | |||
Contributor
There was a problem hiding this comment.
Correspondingly modify the comments.
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| // TODO |
|
|
||
| // TODO | ||
| public static final String ACK_STRATEGY_KEY = "ack-strategy"; | ||
|
|
Contributor
There was a problem hiding this comment.
Need to support specifying ConsumeListener in the property-style constructor.
SteveYurongSu
changed the title
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.