Report error message when deleting template time series with multi-level wildcard pattern#12306
Merged
JackieTien97 merged 6 commits intoapache:masterfrom Apr 19, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #12174, we apply some optimization on deleting time series by pattern ended with multi-level wildcard(**).
However, some corner cases were ignored, which led to inconsistent bahavior with orgin version. For example, if time series
root.db.d1.s1is represented by template, it should not be deleted if client executs commanddelete timeseries root.**.This PR fix this problem.
Reprodeuce step: