Optimize fast compaction memory#12340
Merged
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom Apr 19, 2024
Merged
Conversation
shuwenwei
approved these changes
Apr 16, 2024
HTHou
pushed a commit
that referenced
this pull request
Jun 26, 2024
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the memory usage of FastCompaction from the following two aspects:
Experiment
Experimental Scenario:
There is one sequential file and two unsequential files, all of which completely overlap. Each file contains 5 devices, with each device having 80 time series. Each time series has only one chunk, and each chunk has one page, with 250,000 data points per page. Each timeseries adopts GZIP compression and PLAIN encoding. The experiment simulates a compaction scenario of three-way compacting, with 80 sub threads simultaneously compacting 80 timeseries.
Experimental Procedure:
Using binary search method, adjust the MAX_HEAP_SIZE parameter of the system gradually until the difference between the upper and lower bounds is less than 2M, and then determine the memory usage of the compaction algorithm.
Experimental Results:
Before optimization, FastCompaction algorithm occupies 1327M, and after optimization, it occupies 1187M.