Skip to content

Fix IoTConsensus LogDispatcherThread Stop Using Futrue Cancel#12370

Merged
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
HxpSerein:thread_stop
Apr 18, 2024
Merged

Fix IoTConsensus LogDispatcherThread Stop Using Futrue Cancel#12370
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
HxpSerein:thread_stop

Conversation

@HxpSerein
Copy link
Copy Markdown
Collaborator

@HxpSerein HxpSerein commented Apr 18, 2024

Description

Removing a single LogDispatcherThread does not clean up the threads in the thread pool, which may cause a memory leak.

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 9399399 into apache:master Apr 18, 2024
@HxpSerein HxpSerein deleted the thread_stop branch April 22, 2024 05:53
HTHou pushed a commit that referenced this pull request Jun 26, 2024
* fix LogDispatcherThread stop

* remove parallel
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants