Fix empty wal file deletion#12377
Merged
OneSizeFitsQuorum merged 1 commit intoapache:masterfrom Apr 19, 2024
Merged
Conversation
HTHou
pushed a commit
that referenced
this pull request
Jun 26, 2024
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannnot delete empty wal file because wal uses empty set to represent active file. To fix this problem, I remove this rule and use null to represent active file.
Besides, I use avg size to calculate effective ratio and exclude active file from the calculation. By doing so, wal deletion can cover more corner cases.