Fix redundant lock taking during create multi timeseries#12487
Merged
Beyyes merged 1 commit intoapache:masterfrom May 8, 2024
Merged
Fix redundant lock taking during create multi timeseries#12487Beyyes merged 1 commit intoapache:masterfrom
Beyyes merged 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Cause
The original implementation caused repeating lock taking for all given devices when checking template compatibility for multi timeseries creation. Therefore, if the count of devices in one creation request exceeds 65535, the state count in ReentrantReadWriteLock will overflow, causing the error shown in the picture.
Solution
Make the lock taking only execute once when creating multi timeseries.