Skip to content

JDBC: Fix maxRows cannot be set to 0#12540

Merged
SteveYurongSu merged 1 commit intoapache:masterfrom
Caideyipi:Fix-jdbc
May 17, 2024
Merged

JDBC: Fix maxRows cannot be set to 0#12540
SteveYurongSu merged 1 commit intoapache:masterfrom
Caideyipi:Fix-jdbc

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented May 16, 2024

Description

In a JDBC statement, when the maxRows is 0 it means that there is no limit, therefore we shall allow to set it to 0 to provide function in this case.
img_v3_02au_a36c01e5-33d2-4a4e-ab74-cde35ec4b96g


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Update IoTDBStatement.java Fixed the JDBC bug that maxRows cannot be set to 0 May 16, 2024
@SteveYurongSu SteveYurongSu changed the title Fixed the JDBC bug that maxRows cannot be set to 0 JDBC: Fix maxRows cannot be set to 0 May 16, 2024
@SteveYurongSu SteveYurongSu self-assigned this May 16, 2024
@SteveYurongSu SteveYurongSu merged commit e0eea1d into apache:master May 17, 2024
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants