Skip to content

Generate compaction target file with tier level#12597

Merged
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
shuwenwei:generateCompactionTargetFileWithMaxTier
May 31, 2024
Merged

Generate compaction target file with tier level#12597
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
shuwenwei:generateCompactionTargetFileWithMaxTier

Conversation

@shuwenwei
Copy link
Copy Markdown
Member

Description

Generate compaction target file with tier level

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

long maxVersion = Long.MIN_VALUE;
long maxInnerMergeCount = Long.MIN_VALUE;
long maxCrossMergeCount = Long.MIN_VALUE;
int maxTierLevel = Integer.MIN_VALUE;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use 0 is better.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 6ebaa43 into apache:master May 31, 2024
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
* generate compaction target file with tier level

* modify maxTierLevel to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants