Skip to content

Optimize log for broken wal#12977

Merged
OneSizeFitsQuorum merged 1 commit intomasterfrom
optimize_log_for_broken_wal
Jul 19, 2024
Merged

Optimize log for broken wal#12977
OneSizeFitsQuorum merged 1 commit intomasterfrom
optimize_log_for_broken_wal

Conversation

@jt2594838
Copy link
Copy Markdown
Contributor

Do not print stack traces when the exception is a known one.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.77%. Comparing base (209d263) to head (32147d3).
Report is 26 commits behind head on master.

Files Patch % Lines
...storageengine/dataregion/wal/buffer/WALBuffer.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12977      +/-   ##
============================================
+ Coverage     41.69%   41.77%   +0.07%     
  Complexity       71       71              
============================================
  Files          3324     3327       +3     
  Lines        210525   210812     +287     
  Branches      25018    25098      +80     
============================================
+ Hits          87787    88068     +281     
- Misses       122738   122744       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit ea4fc97 into master Jul 19, 2024
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the optimize_log_for_broken_wal branch July 19, 2024 08:06
JackieTien97 pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants