Skip to content

Replaces the internal maven property with an officially supported alternative#12982

Merged
HTHou merged 1 commit intoapache:masterfrom
bdemers:bdemers/12981-remove-deprecated-mvn
Jul 23, 2024
Merged

Replaces the internal maven property with an officially supported alternative#12982
HTHou merged 1 commit intoapache:masterfrom
bdemers:bdemers/12981-remove-deprecated-mvn

Conversation

@bdemers
Copy link
Copy Markdown
Member

@bdemers bdemers commented Jul 19, 2024

The property maven.multiModuleProjectDirectory is not officially support and can be removed at any time, it has been removed when using mvnd.
The current alternative with Maven 3 is using path traversal from the current module's directory

Fixes: #12981


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

…ernative

The property `maven.multiModuleProjectDirectory` is not officially support and can be removed at any time, it has been removed when using mvnd.
The current alternative with Maven 3 is using path traversal from the current module's directory

Fixes: apache#12981
@bdemers bdemers force-pushed the bdemers/12981-remove-deprecated-mvn branch from 4dd49a7 to 9290a71 Compare July 19, 2024 20:31
@HTHou HTHou merged commit cbabf87 into apache:master Jul 23, 2024
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
…ernative (#12982)

The property `maven.multiModuleProjectDirectory` is not officially support and can be removed at any time, it has been removed when using mvnd.
The current alternative with Maven 3 is using path traversal from the current module's directory

Fixes: #12981
(cherry picked from commit cbabf87)
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
…ernative (#12982)

The property `maven.multiModuleProjectDirectory` is not officially support and can be removed at any time, it has been removed when using mvnd.
The current alternative with Maven 3 is using path traversal from the current module's directory

Fixes: #12981
(cherry picked from commit cbabf87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of maven.multiModuleProjectDirectory property

2 participants