Skip to content

Fix concurrency problem in Memory Control#12984

Merged
OneSizeFitsQuorum merged 3 commits intomasterfrom
feature/optimize_memory
Jul 22, 2024
Merged

Fix concurrency problem in Memory Control#12984
OneSizeFitsQuorum merged 3 commits intomasterfrom
feature/optimize_memory

Conversation

@SpriCoder
Copy link
Copy Markdown
Contributor

Fix concurrency problem in Memory Control

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.77%. Comparing base (0f797e2) to head (64e93d3).

Files Patch % Lines
...tdb/db/storageengine/rescon/memory/SystemInfo.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12984   +/-   ##
=========================================
  Coverage     41.76%   41.77%           
  Complexity       71       71           
=========================================
  Files          3327     3327           
  Lines        210837   210836    -1     
  Branches      25102    25100    -2     
=========================================
+ Hits          88056    88075   +19     
+ Misses       122781   122761   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 76ba733 into master Jul 22, 2024
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the feature/optimize_memory branch July 22, 2024 08:26
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
* fix memory concurrency problem

* spotless

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Co-authored-by: OneSizeFitQuorum <tanxinyu@apache.org>
(cherry picked from commit 76ba733)
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
* fix memory concurrency problem

* spotless

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Co-authored-by: OneSizeFitQuorum <tanxinyu@apache.org>
(cherry picked from commit 76ba733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants