Skip to content

Change some error log to warn during region migration #12992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OneSizeFitsQuorum merged 4 commits into from
Jul 23, 2024
Merged

Change some error log to warn during region migration #12992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68769a2
error -> warn
liyuheng55555 Jul 22, 2024
7644554
warn -> info
liyuheng55555 Jul 22, 2024
52829a4
check file exist before delete
liyuheng55555 Jul 23, 2024
078c1e2
done
liyuheng55555 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public void stop() {
stopped = true;
try {
if (!threadSemaphore.tryAcquire(30, TimeUnit.SECONDS)) {
logger.error("{}: Dispatcher for {} didn't stop after 30s.", impl.getThisNode(), peer);
logger.info("{}: Dispatcher for {} didn't stop after 30s.", impl.getThisNode(), peer);
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
Expand Down
5 changes: 4 additions & 1 deletion ...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ public static boolean clearSnapshotOfDataRegion(DataRegion dataRegion) {
pathBuilder.append(File.separator).append(dataRegion.getDatabaseName());
pathBuilder.append(IoTDBConstant.FILE_NAME_SEPARATOR).append(dataRegion.getDataRegionId());
try {
FileUtils.recursivelyDeleteFolder(pathBuilder.toString());
String path = pathBuilder.toString();
if (new File(path).exists()) {
FileUtils.recursivelyDeleteFolder(path);
}
} catch (IOException e) {
allSuccess = false;
LOGGER.warn(
Expand Down
5 changes: 3 additions & 2 deletions ...node/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,9 @@ public void setBufferSize(int size) {
@Override
public void write(WALEntry walEntry) {
if (isClosed) {
logger.error(
"Fail to write WALEntry into wal node-{} because this node is closed.", identifier);
logger.warn(
"Fail to write WALEntry into wal node-{} because this node is closed. It's ok to see this log during data region deletion.",
identifier);
walEntry.getWalFlushListener().fail(new WALNodeClosedException(identifier));
return;
}
Expand Down