Pipe: Add TsFileEvent deduplication based on Subscription#13167
Closed
Pengzna wants to merge 6 commits intoapache:masterfrom
Closed
Pipe: Add TsFileEvent deduplication based on Subscription#13167Pengzna wants to merge 6 commits intoapache:masterfrom
Pengzna wants to merge 6 commits intoapache:masterfrom
Conversation
… log print when ConfigNodeClient is first constructed.
VGalaxies
reviewed
Aug 14, 2024
Contributor
VGalaxies
left a comment
VGalaxies
left a comment
There was a problem hiding this comment.
If duplicate tsfiles are filtered out during the process stage, maybe the subscription sink won't need to filter again?
Besides, shouldn't it be impossible to get an event of type PipeRawTabletInsertionEvent from inputEventSupplier? cc @SteveYurongSu
luoluoyuyu
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title.
The difference from Subscription is that the duplicate events are directly discarded here without assigning commit id and reporting (to ensure the order of pipeconsensus). Although duplicate events will not be reported, it does not seem to affect the correctness.
refer:
#12887
#12915
#13061