fix scalar function args and return type problem#13244
Merged
JackieTien97 merged 1 commit intoapache:masterfrom Aug 21, 2024
Merged
fix scalar function args and return type problem#13244JackieTien97 merged 1 commit intoapache:masterfrom
JackieTien97 merged 1 commit intoapache:masterfrom
Conversation
…change concat to arg
JackieTien97
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this work is to fix some known issues in scalar functions.
First, the support for timestamp data type in mathematical scalar functions has been removed, considering that the data type of timestamp does not have practical significance in the use of scalar functions. This part has made modifications to all mathematical scalar functions and also to the related IT.
Secondly, support for the || symbol has been added, as the || symbol is semantically consistent with the concat function, so in astbuilder, || is treated as a function call for concat.
Finally, for the return value types of upper, lower, and trim, they have been modified to return string instand of consistently with the input type, which is a modification made according to the actual application requirements.