Skip to content

Add constant folding feature to table model#13333

Merged
JackieTien97 merged 3 commits intomasterfrom
ty/IrExpressionInterpreter
Aug 30, 2024
Merged

Add constant folding feature to table model#13333
JackieTien97 merged 3 commits intomasterfrom
ty/IrExpressionInterpreter

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

  1. Add constant folding feature to table model
    a. only support cast、in expression in this pr, but with this arch we can simply support other built-in functions and operators
  2. change the tsfile dependency version to fix a bug while pushing in filter down to scan
  3. Support cast a string to Timestamp type
  4. Add a new Rule called RemoveTrivialFilters to remove FilterNode whose predicate evaluated to true after constant folding.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 40.26201% with 684 lines in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (861339b) to head (a2fdaf8).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...an/relational/planner/IrExpressionInterpreter.java 38.14% 253 Missing ⚠️
...ssion/multi/builtin/helper/CastFunctionHelper.java 0.00% 99 Missing ⚠️
.../relational/planner/ir/ExpressionTreeRewriter.java 31.30% 79 Missing ⚠️
...engine/plan/relational/planner/IrTypeAnalyzer.java 52.25% 74 Missing ⚠️
...tive/rule/PushDownNegationsExpressionRewriter.java 27.02% 27 Missing ⚠️
...execution/relational/ColumnTransformerBuilder.java 0.00% 17 Missing ⚠️
.../plan/relational/metadata/FunctionNullability.java 0.00% 16 Missing ⚠️
...iterative/rule/CanonicalizeExpressionRewriter.java 57.14% 15 Missing ⚠️
...onal/planner/ir/NormalizeOrExpressionRewriter.java 23.52% 13 Missing ⚠️
...lational/function/ResolvedFunctionCallBuilder.java 0.00% 12 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13333      +/-   ##
============================================
- Coverage     41.03%   41.01%   -0.02%     
  Complexity       71       71              
============================================
  Files          3924     3943      +19     
  Lines        241627   243237    +1610     
  Branches      29153    29417     +264     
============================================
+ Hits          99145    99767     +622     
- Misses       142482   143470     +988     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit bef8547 into master Aug 30, 2024
@JackieTien97 JackieTien97 deleted the ty/IrExpressionInterpreter branch August 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants