Change FileTimeIndexCache to region level#13353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13353 +/- ##
=========================================
Coverage 40.97% 40.98%
Complexity 71 71
=========================================
Files 3929 3929
Lines 242315 242308 -7
Branches 29251 29248 -3
=========================================
+ Hits 99296 99308 +12
+ Misses 143019 143000 -19 ☔ View full report in Codecov by Sentry. |
|
|
|
||
| private final Map<Integer, Map<Long, FileTimeIndexCacheWriter>> writerMap = | ||
| new ConcurrentHashMap<>(); | ||
| private final Map<Integer, FileTimeIndexCacheWriter> writerMap = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Add a comment to explain that the key is the data region id.
|
One potential improvement: the compaction task clears the cache file at first. If a restart happens at that time, there will be no available cache file for this restart, and the system may suffer from a long restart time. |
* Check FileTimeIndexCache to region level * add log * fix ut * fix it error * fix error log
* Check FileTimeIndexCache to region level * add log * fix ut * fix it error * fix error log



Description
FileTimeIndexCache may open too much file if there is too much time partitions.