Allow duplicated column names in table model #13444
Merged
JackieTien97 merged 11 commits intomasterfrom Sep 10, 2024
Merged
Conversation
…e/iotdb into allowDuplicatedColumnNames
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13444 +/- ##
============================================
+ Coverage 41.32% 41.36% +0.04%
Complexity 71 71
============================================
Files 3961 3961
Lines 245128 245184 +56
Branches 29687 29693 +6
============================================
+ Hits 101287 101418 +131
+ Misses 143841 143766 -75 ☔ View full report in Codecov by Sentry. |
|
Beyyes
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Previously, if we have duplicated column names in ResultSet, it may throw exception

In this pr, we add an optional field in response to support duplicated column names. And I also refactor the

IoTDBRpcDateSetclass which is so ugly.