Skip to content

Allow duplicated column names in table model #13444

Merged
JackieTien97 merged 11 commits intomasterfrom
allowDuplicatedColumnNames
Sep 10, 2024
Merged

Allow duplicated column names in table model #13444
JackieTien97 merged 11 commits intomasterfrom
allowDuplicatedColumnNames

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

Previously, if we have duplicated column names in ResultSet, it may throw exception
img_v3_02ef_c018fd18-dbfb-4902-b81f-60478edb817g

In this pr, we add an optional field in response to support duplicated column names. And I also refactor the IoTDBRpcDateSet class which is so ugly.
image

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 81 lines in your changes missing coverage. Please review.

Project coverage is 41.36%. Comparing base (2cbd077) to head (c7b7744).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/org/apache/iotdb/rpc/IoTDBRpcDataSet.java 51.61% 60 Missing ⚠️
...java/org/apache/iotdb/isession/SessionDataSet.java 38.46% 8 Missing ⚠️
...java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java 41.66% 7 Missing ⚠️
...ava/org/apache/iotdb/session/ThriftConnection.java 0.00% 2 Missing ⚠️
.../db/protocol/thrift/impl/ClientRPCServiceImpl.java 0.00% 2 Missing ⚠️
...rc/main/java/org/apache/iotdb/cli/AbstractCli.java 0.00% 1 Missing ⚠️
...db/db/queryengine/common/header/DatasetHeader.java 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13444      +/-   ##
============================================
+ Coverage     41.32%   41.36%   +0.04%     
  Complexity       71       71              
============================================
  Files          3961     3961              
  Lines        245128   245184      +56     
  Branches      29687    29693       +6     
============================================
+ Hits         101287   101418     +131     
+ Misses       143841   143766      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 9, 2024

@JackieTien97 JackieTien97 merged commit 15365ff into master Sep 10, 2024
@JackieTien97 JackieTien97 deleted the allowDuplicatedColumnNames branch September 10, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants