Modify the exception thrown when the date conversion year overflows#13711
Merged
JackieTien97 merged 6 commits intoapache:masterfrom Oct 13, 2024
Merged
Modify the exception thrown when the date conversion year overflows#13711JackieTien97 merged 6 commits intoapache:masterfrom
JackieTien97 merged 6 commits intoapache:masterfrom
Conversation
FearfulTomcat27
force-pushed
the
fix/dateException
branch
from
9e30571 to
ec445ff
Compare
JackieTien97
approved these changes
Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance arithmetic operations in the IoTDB project, particularly focusing on handling date arithmetic and overflow scenarios. The key updates include adding a new status code for date out-of-range errors, updating test cases to cover these scenarios, and refining the error handling logic.
Enhancements to Arithmetic Operations:
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/TSStatusCode.java: Added a new status codeDATE_OUT_OF_RANGEto handle date-related errors.Test Case Updates:
integration-test/src/test/java/org/apache/iotdb/relational/it/query/old/query/IoTDBArithmeticTableIT.java: Added new test cases for date arithmetic operations and overflow scenarios. [1] [2]Error Handling Improvements:
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java: Updated the error handling logic to include the newDATE_OUT_OF_RANGEstatus code.Code Generation Templates:
iotdb-core/datanode/src/main/codegen/templates/ArithmeticBinaryColumnTransformer.ftl: Enhanced the arithmetic binary column transformer to handle date arithmetic and overflow scenarios more robustly, including catchingDateTimeParseExceptionand throwing a newIoTDBRuntimeExceptionfor date out-of-range errors.