Fix exception when casewhen function meets two conditions#13716
Merged
JackieTien97 merged 6 commits intoapache:masterfrom Oct 17, 2024
Merged
Fix exception when casewhen function meets two conditions#13716JackieTien97 merged 6 commits intoapache:masterfrom
JackieTien97 merged 6 commits intoapache:masterfrom
Conversation
… of TimeColumnTransformer short-circuiting.
JackieTien97
requested changes
Oct 14, 2024
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
change all your Chinese comments to English
...he/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java
Outdated
Show resolved
Hide resolved
...he/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java
Show resolved
Hide resolved
...he/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java
Outdated
Show resolved
Hide resolved
...he/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java
Show resolved
Hide resolved
...he/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java
Outdated
Show resolved
Hide resolved
JackieTien97
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test case and improves the logic for handling
CASE WHENtransformations. The most important changes include adding a new test to verify multipleWHENclause satisfaction and enhancing the transformation logic to handle uninitialized branches.New Test Case:
integration-test/src/test/java/org/apache/iotdb/db/it/query/IoTDBCaseWhenThenIT.java: Added a new test methodtestMultipleSatisfyCaseto verify the behavior when multipleWHENclauses are satisfied.Transformation Logic Improvement:
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/AbstractCaseWhenThenColumnTransformer.java: Updated thedoTransformmethod to include a check for uninitialized branches (branchIndexForEachRow[j] == -1).