Skip to content

Add aggregation table scan impl for table model#13720

Merged
Beyyes merged 26 commits intomasterfrom
agg_table_scan
Oct 13, 2024
Merged

Add aggregation table scan impl for table model#13720
Beyyes merged 26 commits intomasterfrom
agg_table_scan

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 11, 2024

Description

Content1 ...

In this pr, aggregation table scan is supported, the example sql is:
select count(num) as count_num, avg(num) as avg_num, count(num) as count_num, count(attr2) as count_attr2, avg(num) as avg_num, count(device) as count_device, count(attr1) as count_attr1, count(device) as count_device, round(avg(floatnum)) as avg_floatnum, count(date) as count_date, count(time) as count_time, count(*) as count_star from table1;.

image


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 5.98456% with 487 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (afd57ba) to head (735e345).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../relational/TableAggregationTableScanOperator.java 0.00% 275 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 113 Missing ⚠️
...ational/planner/node/AggregationTableScanNode.java 14.28% 42 Missing ⚠️
.../source/relational/aggregation/AvgAccumulator.java 0.00% 19 Missing ⚠️
...ource/relational/aggregation/CountAccumulator.java 0.00% 10 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 20.00% 8 Missing ⚠️
...ution/operator/process/TagAggregationOperator.java 0.00% 5 Missing ⚠️
...ce/relational/aggregation/AggregationOperator.java 0.00% 4 Missing ⚠️
...source/relational/aggregation/TableAggregator.java 0.00% 4 Missing ⚠️
...er/distribute/TableModelTypeProviderExtractor.java 50.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13720      +/-   ##
============================================
- Coverage     41.04%   40.98%   -0.06%     
  Complexity       71       71              
============================================
  Files          4031     4032       +1     
  Lines        252013   252454     +441     
  Branches      30705    30809     +104     
============================================
+ Hits         103433   103463      +30     
- Misses       148580   148991     +411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Beyyes Beyyes merged commit 207f90a into master Oct 13, 2024
@Beyyes Beyyes deleted the agg_table_scan branch October 13, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants