Skip to content

Add aggregation+DateBin groupby support(aggregation table scan) and SumAccumulator support for table model.#13771

Merged
JackieTien97 merged 6 commits intomasterfrom
agg_table_scan_groupby
Oct 15, 2024
Merged

Add aggregation+DateBin groupby support(aggregation table scan) and SumAccumulator support for table model.#13771
JackieTien97 merged 6 commits intomasterfrom
agg_table_scan_groupby

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 15, 2024

Description

  1. Support group by date_bin in aggregation table scan process.
  2. Support SumAccumulator for aggregation process.

Some examples are as below:

image


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Beyyes Beyyes changed the title Add datebin support for aggregation table scan. Add datebin groupby support for aggregation table scan. Oct 15, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Beyyes Beyyes changed the title Add datebin groupby support for aggregation table scan. Add aggregation+DateBin groupby support(aggregation table scan) and SumAccumulator support for table model. Oct 15, 2024
@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 280 lines in your changes missing coverage. Please review.

Project coverage is 40.82%. Comparing base (b6a30e8) to head (e2f5a93).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../relational/TableAggregationTableScanOperator.java 0.00% 121 Missing ⚠️
.../source/relational/aggregation/SumAccumulator.java 0.00% 70 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 27 Missing ⚠️
...merangeiterator/TableDateBinTimeRangeIterator.java 0.00% 22 Missing ⚠️
...unary/scalar/DateBinFunctionColumnTransformer.java 0.00% 19 Missing ⚠️
...merangeiterator/TableSingleTimeWindowIterator.java 0.00% 14 Missing ⚠️
...ion/timerangeiterator/ITableTimeRangeIterator.java 0.00% 3 Missing ⚠️
...onal/metadata/TableBuiltinAggregationFunction.java 0.00% 2 Missing ⚠️
...rce/relational/aggregation/AccumulatorFactory.java 0.00% 1 Missing ⚠️
.../source/relational/aggregation/AvgAccumulator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13771      +/-   ##
============================================
- Coverage     40.88%   40.82%   -0.06%     
  Complexity       71       71              
============================================
  Files          4043     4057      +14     
  Lines        253208   253947     +739     
  Branches      30884    31000     +116     
============================================
+ Hits         103517   103670     +153     
- Misses       149691   150277     +586     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit f401e9a into master Oct 15, 2024
@JackieTien97 JackieTien97 deleted the agg_table_scan_groupby branch October 15, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants