Subscription: improve event consistency by operating within the compute method#13787
Merged
SteveYurongSu merged 3 commits intoapache:masterfrom Oct 16, 2024
Merged
Subscription: improve event consistency by operating within the compute method#13787SteveYurongSu merged 3 commits intoapache:masterfrom
compute method#13787SteveYurongSu merged 3 commits intoapache:masterfrom
Conversation
SteveYurongSu
approved these changes
Oct 16, 2024
VGalaxies
added a commit
to VGalaxies/iotdb
that referenced
this pull request
Oct 16, 2024
SteveYurongSu
pushed a commit
that referenced
this pull request
Oct 17, 2024
Caideyipi
pushed a commit
to Caideyipi/iotdb
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure consistency while holding this lock in prefetching queue (although it does not enforce mutual exclusion among the other operations themselves.), updates to the SubscriptionEvent in both SubscriptionPrefetchingQueue#prefetchingQueue and SubscriptionPrefetchingQueue#inFlightEvents must be performed within the ConcurrentHashMap#compute method of inFlightEvents in the SubscriptionPrefetchingQueue.