Skip to content

Active Load: Adjust the default execution thread to match the number of CPU cores #13865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 1 commit into from
Oct 22, 2024
Merged

Active Load: Adjust the default execution thread to match the number of CPU cores #13865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ public class IoTDBConfig {

private long loadActiveListeningCheckIntervalSeconds = 5L;

private int loadActiveListeningMaxThreadNum = 8;
private int loadActiveListeningMaxThreadNum = Runtime.getRuntime().availableProcessors();

/** Pipe related */
/** initialized as empty, updated based on the latest `systemDir` during querying */
Expand Down
16 changes: 6 additions & 10 deletions iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2357,19 +2357,15 @@ private void loadLoadTsFileProps(Properties properties) {
? conf.getLoadActiveListeningCheckIntervalSeconds()
: loadActiveListeningCheckIntervalSeconds);

final int defaultLoadActiveListeningMaxThreadNum =
Math.min(
conf.getLoadActiveListeningMaxThreadNum(),
Math.max(1, Runtime.getRuntime().availableProcessors() / 2));
final int loadActiveListeningMaxThreadNum =
conf.setLoadActiveListeningMaxThreadNum(
Integer.parseInt(
properties.getProperty(
"load_active_listening_max_thread_num",
Integer.toString(defaultLoadActiveListeningMaxThreadNum)));
conf.setLoadActiveListeningMaxThreadNum(
loadActiveListeningMaxThreadNum <= 0
? defaultLoadActiveListeningMaxThreadNum
: loadActiveListeningMaxThreadNum);
Integer.toString(conf.getLoadActiveListeningMaxThreadNum()))));

if (conf.getLoadActiveListeningMaxThreadNum() <= 0) {
conf.setLoadActiveListeningMaxThreadNum(Runtime.getRuntime().availableProcessors());
}
}

private void loadLoadTsFileHotModifiedProp(Properties properties) throws IOException {
Expand Down
4 changes: 2 additions & 2 deletions iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1949,10 +1949,10 @@ load_active_listening_dirs=ext/load/pending
load_active_listening_fail_dir=ext/load/failed

# The maximum number of threads that can be used to load tsfile actively.
# The default value, when this parameter is commented out, is the minimum of 8 or the number of CPU cores.
# The default value, when this parameter is commented out or <= 0, use CPU core number.
# effectiveMode: restart
# Datatype: int
load_active_listening_max_thread_num=8
load_active_listening_max_thread_num=0

# The interval specified in seconds for the active listening mode to check the directory specified in load_active_listening_dirs.
# The active listening mode will check the directory every load_active_listening_check_interval_seconds seconds.
Expand Down