Load: create DB in lower-case & truncate null suffix of device ID#13966
Merged
SteveYurongSu merged 4 commits intoapache:masterfrom Nov 1, 2024
Merged
Load: create DB in lower-case & truncate null suffix of device ID#13966SteveYurongSu merged 4 commits intoapache:masterfrom
SteveYurongSu merged 4 commits intoapache:masterfrom
Conversation
luoluoyuyu
reviewed
Oct 31, 2024
Comment on lines
227
to
228
| deviceIdArray[realColumnIndex] = device.getSegments()[fileColumnIndex + 1]; | ||
| } |
Member
There was a problem hiding this comment.
device.getSegments()[fileColumnIndex + 1] will cause array out of bounds. If a table is defined with an id, when the id of a row is null, the length of device.getSegments() is 1 and the content is only [table], and the null value will not be saved.
luoluoyuyu
approved these changes
Oct 31, 2024
SteveYurongSu
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.