Fix non deterministic test - RoleTest#testRole_InitAndSerialize#13981
Open
mohitbadve wants to merge 2 commits intoapache:masterfrom
Open
Fix non deterministic test - RoleTest#testRole_InitAndSerialize#13981mohitbadve wants to merge 2 commits intoapache:masterfrom
mohitbadve wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test
org.apache.iotdb.db.auth.entity.RoleTest#testRole_InitAndSerializefails under NonDex tool which detects non-deterministic nature of tests with when non-deterministic data structures are used. The failure behavior is defined by non-deterministic ordering ofpathPrivilegeListandsystemPrivilegeSet.How to Reproduce
Error
Proposed Solution
Assert the role.toString by handling the above catch. Extract and assert the list and set instead of asserting string directly.
Please let me know if you have any questions or need any additional justification/changes from my side.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR