Fix ConfignNode LoadManager NPE when removing datanodes#14016
Merged
OneSizeFitsQuorum merged 1 commit intomasterfrom Nov 8, 2024
Merged
Fix ConfignNode LoadManager NPE when removing datanodes#14016OneSizeFitsQuorum merged 1 commit intomasterfrom
OneSizeFitsQuorum merged 1 commit intomasterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14016 +/- ##
============================================
- Coverage 39.95% 39.87% -0.09%
Complexity 71 71
============================================
Files 4191 4201 +10
Lines 265837 266569 +732
Branches 32266 32323 +57
============================================
+ Hits 106222 106283 +61
- Misses 159615 160286 +671 ☔ View full report in Codecov by Sentry. |
liyuheng55555
approved these changes
Nov 8, 2024
Collaborator
liyuheng55555
left a comment
liyuheng55555
left a comment
There was a problem hiding this comment.
Excellent use of Optional !
HxpSerein
pushed a commit
to HxpSerein/iotdb
that referenced
this pull request
Dec 3, 2024
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit b39c325)
OneSizeFitsQuorum
added a commit
that referenced
this pull request
Dec 6, 2024
…14301) * Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing #13517 (cherry picked from commit 5599859) * Remove datanode optimization (#13559) (cherry picked from commit cc73946) * Split CnToDnRequestType to sync and async & Add check for adding new request type (#13660) (cherry picked from commit 8187498) * Enhance Remove DataNode Test (#13809) (cherry picked from commit 063fddd) * [remove datanode] Identify and display invalid nodes before removing #13987 (cherry picked from commit 387b4bf) * [remove datanode] Fixed jvm heap memory in remove datanode script (#13983) (cherry picked from commit 78e6f3a) * [remove datanode] Enhance remove message on environment with only ConfigNode #14007 (cherry picked from commit db7c522) * Remove useless log "datanodeId -1" #14035 (cherry picked from commit 8a92aaf) * [remove datanode] Log the node information when submitting RegionMigrateProcedure (#14051) (cherry picked from commit e437ef3) * [remove datanode] Enhance remove message on environment with only ConfigNode #14123 (cherry picked from commit f3afc20) * [remove datanode] Refuse to remove when there are any other unknown or readonly DataNodes in the consensus group (#14145) * add uknown check * remove useless check (cherry picked from commit adcedc0) * Fix stopping cn leader stuck when region region migration #14175 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit 9b22f7c) * [remove datanode] Do not allow regions to inherit the Removing state from datanode (#14185) (cherry picked from commit 8a6405c) * [remove datanode] Do not disable the entire region group for one removing region (#14241) * fix disabled * fix disabled (cherry picked from commit 041d292) * [remove datanode] Not re-submit region migration procedure when leader change or reboot #14277 (cherry picked from commit d101d76) * Fix ConfignNode LoadManager NPE when removing datanodes #14016 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit b39c325) * Fix ConfigNode Partition Metric NPE bug #14144 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit 4a76dfb) * Enhance procedure recover policy (cherry picked from commit 496c62e) * remove table * fix IT --------- Co-authored-by: Li Yu Heng <liyuheng55555@126.com> Co-authored-by: Potato <tanxinyu@apache.org>
Caideyipi
pushed a commit
to Caideyipi/iotdb
that referenced
this pull request
Mar 25, 2026
…pache#14301) * Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing apache#13517 (cherry picked from commit 5599859) * Remove datanode optimization (apache#13559) (cherry picked from commit cc73946) * Split CnToDnRequestType to sync and async & Add check for adding new request type (apache#13660) (cherry picked from commit 8187498) * Enhance Remove DataNode Test (apache#13809) (cherry picked from commit 063fddd) * [remove datanode] Identify and display invalid nodes before removing apache#13987 (cherry picked from commit 387b4bf) * [remove datanode] Fixed jvm heap memory in remove datanode script (apache#13983) (cherry picked from commit 78e6f3a) * [remove datanode] Enhance remove message on environment with only ConfigNode apache#14007 (cherry picked from commit db7c522) * Remove useless log "datanodeId -1" apache#14035 (cherry picked from commit 8a92aaf) * [remove datanode] Log the node information when submitting RegionMigrateProcedure (apache#14051) (cherry picked from commit e437ef3) * [remove datanode] Enhance remove message on environment with only ConfigNode apache#14123 (cherry picked from commit f3afc20) * [remove datanode] Refuse to remove when there are any other unknown or readonly DataNodes in the consensus group (apache#14145) * add uknown check * remove useless check (cherry picked from commit adcedc0) * Fix stopping cn leader stuck when region region migration apache#14175 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit 9b22f7c) * [remove datanode] Do not allow regions to inherit the Removing state from datanode (apache#14185) (cherry picked from commit 8a6405c) * [remove datanode] Do not disable the entire region group for one removing region (apache#14241) * fix disabled * fix disabled (cherry picked from commit 041d292) * [remove datanode] Not re-submit region migration procedure when leader change or reboot apache#14277 (cherry picked from commit d101d76) * Fix ConfignNode LoadManager NPE when removing datanodes apache#14016 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit b39c325) * Fix ConfigNode Partition Metric NPE bug apache#14144 Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org> (cherry picked from commit 4a76dfb) * Enhance procedure recover policy (cherry picked from commit 496c62e) * remove table * fix IT --------- Co-authored-by: Li Yu Heng <liyuheng55555@126.com> Co-authored-by: Potato <tanxinyu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Datanodes are currently removed, the deletion of some maps of cn loadmanager and the callback of asynchronous rpc may have some concurrency conflicts. In this case, some robustness needs to be improved