Optimize first, last, first_by, last_by aggregation process in table model#14192
Merged
JackieTien97 merged 1 commit intomasterfrom Nov 25, 2024
Merged
Optimize first, last, first_by, last_by aggregation process in table model#14192JackieTien97 merged 1 commit intomasterfrom
JackieTien97 merged 1 commit intomasterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14192 +/- ##
============================================
- Coverage 39.61% 39.59% -0.03%
Complexity 71 71
============================================
Files 4232 4232
Lines 269671 269791 +120
Branches 32689 32713 +24
============================================
- Hits 106837 106811 -26
- Misses 162834 162980 +146 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
JackieTien97
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
For first, first_by, last and last_by aggregations, actually we can only read the first value/statistics and then terminate the process.
There is no need to read all values.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR