Skip to content

Optimize first, last, first_by, last_by aggregation process in table model#14192

Merged
JackieTien97 merged 1 commit intomasterfrom
fix_last_by_max_time
Nov 25, 2024
Merged

Optimize first, last, first_by, last_by aggregation process in table model#14192
JackieTien97 merged 1 commit intomasterfrom
fix_last_by_max_time

Conversation

@Beyyes
Copy link
Copy Markdown
Member

@Beyyes Beyyes commented Nov 25, 2024

Description

For first, first_by, last and last_by aggregations, actually we can only read the first value/statistics and then terminate the process.

There is no need to read all values.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (34228a9) to head (3eb07fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../relational/aggregation/LastByDescAccumulator.java 0.00% 30 Missing ⚠️
...ce/relational/aggregation/LastDescAccumulator.java 0.00% 30 Missing ⚠️
...relational/aggregation/FirstByDescAccumulator.java 0.00% 24 Missing ⚠️
...e/relational/aggregation/FirstDescAccumulator.java 0.00% 24 Missing ⚠️
...ource/relational/aggregation/FirstAccumulator.java 0.00% 6 Missing ⚠️
...rce/relational/aggregation/FirstByAccumulator.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14192      +/-   ##
============================================
- Coverage     39.61%   39.59%   -0.03%     
  Complexity       71       71              
============================================
  Files          4232     4232              
  Lines        269671   269791     +120     
  Branches      32689    32713      +24     
============================================
- Hits         106837   106811      -26     
- Misses       162834   162980     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JackieTien97 JackieTien97 merged commit 8491391 into master Nov 25, 2024
@JackieTien97 JackieTien97 deleted the fix_last_by_max_time branch November 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants