Skip to content

Refactor mod-file-related FileMetric#14199

Merged
jt2594838 merged 3 commits intomasterfrom
refactor_mod_metric
Nov 26, 2024
Merged

Refactor mod-file-related FileMetric#14199
jt2594838 merged 3 commits intomasterfrom
refactor_mod_metric

Conversation

@jt2594838
Copy link
Copy Markdown
Contributor

Mod-file-related FileMetrics are managed within the Modification to ease the management and reduce potential bugs.

Copy link
Copy Markdown
Collaborator

@Pengzna Pengzna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (34228a9) to head (720699e).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
.../iotdb/db/storageengine/dataregion/DataRegion.java 33.33% 2 Missing ⚠️
...gine/dataregion/modification/ModificationFile.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14199      +/-   ##
============================================
+ Coverage     39.61%   39.62%   +0.01%     
  Complexity       71       71              
============================================
  Files          4232     4233       +1     
  Lines        269671   270007     +336     
  Branches      32689    32746      +57     
============================================
+ Hits         106837   107003     +166     
- Misses       162834   163004     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jt2594838 jt2594838 merged commit 293746e into master Nov 26, 2024
@HTHou HTHou deleted the refactor_mod_metric branch January 6, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants