Skip to content

Fix error in single device with sort + offset + limit align by device query#14245

Merged
JackieTien97 merged 3 commits intomasterfrom
fix_alignbydevice_offset_limit
Nov 29, 2024
Merged

Fix error in single device with sort + offset + limit align by device query#14245
JackieTien97 merged 3 commits intomasterfrom
fix_alignbydevice_offset_limit

Conversation

@Beyyes
Copy link
Copy Markdown
Member

@Beyyes Beyyes commented Nov 28, 2024

Description

Before fix:
image
image

After fix:
image
image


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.63%. Comparing base (b34b714) to head (61611bd).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14245   +/-   ##
=========================================
  Coverage     39.62%   39.63%           
  Complexity       71       71           
=========================================
  Files          4242     4242           
  Lines        270437   270472   +35     
  Branches      32792    32803   +11     
=========================================
+ Hits         107165   107205   +40     
+ Misses       163272   163267    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes changed the title fix single device align by device query Fix error in single device with sort align by device query Nov 29, 2024
@Beyyes Beyyes changed the title Fix error in single device with sort align by device query Fix error in single device with sort offset limit align by device query Nov 29, 2024
@Beyyes Beyyes changed the title Fix error in single device with sort offset limit align by device query Fix error in single device with sort + offset + limit align by device query Nov 29, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit c5eacf0 into master Nov 29, 2024
@JackieTien97 JackieTien97 deleted the fix_alignbydevice_offset_limit branch November 29, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants