Skip to content

Support table model sql insertion without column name#14310

Merged
jt2594838 merged 2 commits intomasterfrom
insert_without_column_name
Dec 6, 2024
Merged

Support table model sql insertion without column name#14310
jt2594838 merged 2 commits intomasterfrom
insert_without_column_name

Conversation

@jt2594838
Copy link
Contributor

When not specifying the column names, the number of inputing columns must be exactly the same as those already defined in the database. Also, they must have the same order, otherwise, the insertion will fail.

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 11.00000% with 89 lines in your changes missing coverage. Please review.

Project coverage is 39.54%. Comparing base (54a6d81) to head (0bf5b17).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...yengine/plan/relational/sql/parser/AstBuilder.java 2.35% 83 Missing ⚠️
.../db/protocol/thrift/impl/ClientRPCServiceImpl.java 0.00% 3 Missing ⚠️
...ne/plan/relational/analyzer/StatementAnalyzer.java 0.00% 2 Missing ⚠️
...otdb/db/queryengine/plan/analyze/AnalyzeUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14310      +/-   ##
============================================
- Coverage     39.55%   39.54%   -0.01%     
  Complexity       71       71              
============================================
  Files          4253     4253              
  Lines        271542   271581      +39     
  Branches      32930    32941      +11     
============================================
- Hits         107413   107403      -10     
- Misses       164129   164178      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

@jt2594838 jt2594838 merged commit b1e6904 into master Dec 6, 2024
@JackieTien97 JackieTien97 deleted the insert_without_column_name branch December 6, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants