Skip to content

Conversation

@HTHou
Copy link
Contributor

@HTHou HTHou commented Dec 12, 2024

Description

The nonFullCondition in MemoryControlledWALEntryQueue should be static. Otherwise, the MemoryControlledWALEntryQueue may stuck.

This PR also fixed the wal_queue_max_mem_size metric no data problem.

@sonarqubecloud
Copy link

@HTHou HTHou changed the title Fix wal queue stuck and fix metric Fix wal queue stuck and fix wal_queue_max_mem_size metric Dec 12, 2024
@HTHou HTHou marked this pull request as ready for review December 12, 2024 03:33
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.67%. Comparing base (5898668) to head (5bbd332).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...pache/iotdb/db/service/metrics/WritingMetrics.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14387      +/-   ##
============================================
- Coverage     39.68%   39.67%   -0.02%     
  Complexity      185      185              
============================================
  Files          4326     4327       +1     
  Lines        274726   274911     +185     
  Branches      33354    33385      +31     
============================================
+ Hits         109036   109072      +36     
- Misses       165690   165839     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jt2594838 jt2594838 merged commit ba82454 into master Dec 12, 2024
36 of 37 checks passed
@HTHou HTHou deleted the fix_wal_queue_stack branch December 12, 2024 06:31
HTHou added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants