Add database name for table model CLI#14544
Merged
JackieTien97 merged 3 commits intoapache:masterfrom Dec 25, 2024
Merged
Conversation
JackieTien97
requested changes
Dec 25, 2024
| private static void updateUsingDatabaseIfNecessary(String database) { | ||
| if (!Objects.equals(usingDatabase, database)) { | ||
| usingDatabase = database; | ||
| if (sqlDialect != null && Model.TABLE.name().equals(sqlDialect.toUpperCase())) { |
Contributor
There was a problem hiding this comment.
what if usingDatabase is null? IOTDB_CLI_PREFIX should be IOTDB instead of "IOTDB:"
Collaborator
Author
There was a problem hiding this comment.
OK, I've changed this part
Collaborator
Author
There was a problem hiding this comment.
But still wondering in which case the "usingDatabase" will changed from not-null to null, seems we don't have "unuse database" statement for now
JackieTien97
approved these changes
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.