Skip to content

Add High Level Memory Threshold Metrics#14568

Merged
OneSizeFitsQuorum merged 7 commits intomasterfrom
feature/optimize_memory
Dec 27, 2024
Merged

Add High Level Memory Threshold Metrics#14568
OneSizeFitsQuorum merged 7 commits intomasterfrom
feature/optimize_memory

Conversation

@SpriCoder
Copy link
Copy Markdown
Contributor

Add High-Level Memory Threshold Metrics(Total, Storage Engine, Query Engine, Schema Engine, Consensus, Stream Engine, Direct Buffer)

@sonarqubecloud
Copy link
Copy Markdown

@SpriCoder
Copy link
Copy Markdown
Contributor Author

Panel:
image

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 3.07692% with 126 lines in your changes missing coverage. Please review.

Project coverage is 39.40%. Comparing base (530dd0b) to head (05b0757).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...service/metrics/memory/ThresholdMemoryMetrics.java 0.00% 91 Missing ⚠️
...otdb/db/service/metrics/DataNodeMetricsHelper.java 0.00% 35 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14568      +/-   ##
============================================
- Coverage     39.42%   39.40%   -0.02%     
  Complexity      185      185              
============================================
  Files          4341     4342       +1     
  Lines        275397   275494      +97     
  Branches      33639    33639              
============================================
- Hits         108566   108559       -7     
- Misses       166831   166935     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tag.TYPE.toString(),
"OffHeap",
Tag.LEVEL.toString(),
"1");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could define some field for these magic level string,could do it in next pr

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 8a4f600 into master Dec 27, 2024
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the feature/optimize_memory branch December 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants