Skip to content

Close Aggregation and State to release resource#14579

Merged
JackieTien97 merged 2 commits intomasterfrom
udaf_refine
Dec 30, 2024
Merged

Close Aggregation and State to release resource#14579
JackieTien97 merged 2 commits intomasterfrom
udaf_refine

Conversation

@Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented Dec 29, 2024

Description

Close Aggregation and State to release resource

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 39.41%. Comparing base (3238ec2) to head (cc15397).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
.../relational/TableAggregationTableScanOperator.java 0.00% 3 Missing ⚠️
...ation/UserDefinedAggregateFunctionAccumulator.java 0.00% 3 Missing ⚠️
...rouped/GroupedUserDefinedAggregateAccumulator.java 0.00% 3 Missing ⚠️
...source/relational/aggregation/TableAggregator.java 0.00% 2 Missing ⚠️
...ational/aggregation/grouped/GroupedAggregator.java 0.00% 2 Missing ⚠️
...ce/relational/aggregation/AggregationOperator.java 0.00% 1 Missing ⚠️
...ource/relational/aggregation/TableAccumulator.java 0.00% 1 Missing ⚠️
...tional/aggregation/grouped/GroupedAccumulator.java 0.00% 1 Missing ⚠️
...l/aggregation/grouped/HashAggregationOperator.java 0.00% 1 Missing ⚠️
...regation/grouped/StreamingAggregationOperator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14579      +/-   ##
============================================
- Coverage     39.41%   39.41%   -0.01%     
- Complexity      185      193       +8     
============================================
  Files          4341     4343       +2     
  Lines        275386   275500     +114     
  Branches      33639    33637       -2     
============================================
+ Hits         108550   108591      +41     
- Misses       166836   166909      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 554d7d8 into master Dec 30, 2024
@JackieTien97 JackieTien97 deleted the udaf_refine branch December 30, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants