Skip to content

Enable tree data to be queried by a table view [PART-1]#14614

Merged
JackieTien97 merged 18 commits intomasterfrom
TreeToTableView
Jan 2, 2025
Merged

Enable tree data to be queried by a table view [PART-1]#14614
JackieTien97 merged 18 commits intomasterfrom
TreeToTableView

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

  1. refactor the code to reduce duplicated code in serde processing of some plannodes
  2. prepare PlanNode and Operator for tree to table view

@Beyyes Beyyes requested review from Beyyes and Wei-hao-Li January 2, 2025 10:45
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 29.53082% with 766 lines in your changes missing coverage. Please review.

Project coverage is 39.40%. Comparing base (5ebbb8d) to head (7ea5df4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...r/source/relational/AbstractTableScanOperator.java 2.73% 142 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 3.00% 129 Missing ⚠️
...ational/planner/node/AggregationTableScanNode.java 32.43% 75 Missing ⚠️
...ne/plan/relational/planner/node/TableScanNode.java 1.49% 66 Missing ⚠️
...ource/relational/AbstractAggTableScanOperator.java 0.00% 59 Missing ⚠️
...elational/planner/node/TreeDeviceViewScanNode.java 23.21% 43 Missing ⚠️
...lanner/node/AggregationTreeDeviceViewScanNode.java 14.58% 41 Missing ⚠️
...elational/AbstractDefaultAggTableScanOperator.java 0.00% 38 Missing ⚠️
...n/relational/planner/node/DeviceTableScanNode.java 9.75% 37 Missing ⚠️
...ne/plan/relational/planner/optimizations/Util.java 52.38% 20 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14614      +/-   ##
============================================
+ Coverage     39.36%   39.40%   +0.03%     
  Complexity      193      193              
============================================
  Files          4352     4363      +11     
  Lines        276084   276549     +465     
  Branches      33732    33753      +21     
============================================
+ Hits         108684   108966     +282     
- Misses       167400   167583     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 256737f into master Jan 2, 2025
@JackieTien97 JackieTien97 deleted the TreeToTableView branch January 6, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants