Skip to content

Reduce some deletion-related log levels #14631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 1 commit into from
Jan 6, 2025
Merged

Reduce some deletion-related log levels #14631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions ...-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,9 +2287,9 @@ public void deleteByTable(RelationalDeleteDataNode node) throws IOException {
unsealedTsFileResource,
modEntry.getStartTime(),
modEntry.getEndTime());
logger.info("[Deletion] unsealed files for {}: {}", modEntry, unsealedTsFileResource);
logger.debug("[Deletion] unsealed files for {}: {}", modEntry, unsealedTsFileResource);
deleteDataInUnsealedFiles(unsealedTsFileResource, modEntry, sealedTsFileResource);
logger.info("[Deletion] sealed files for {}: {}", modEntry, sealedTsFileResource);
logger.debug("[Deletion] sealed files for {}: {}", modEntry, sealedTsFileResource);
sealedTsFileResourceLists.add(sealedTsFileResource);
}

Expand Down Expand Up @@ -2464,7 +2464,7 @@ private boolean canSkipDelete(TsFileResource tsFileResource, ModEntry deletion)

if (!ModificationUtils.overlap(
deletion.getStartTime(), deletion.getEndTime(), fileStartTime, fileEndTime)) {
logger.info(
logger.debug(
"[Deletion] {} skipped {}, file time [{}, {}]",
deletion,
tsFileResource,
Expand All @@ -2487,7 +2487,7 @@ private boolean canSkipDelete(TsFileResource tsFileResource, ModEntry deletion)
return false;
}
}
logger.info("[Deletion] {} skipped {}, file time {}", deletion, tsFileResource, timeIndex);
logger.debug("[Deletion] {} skipped {}, file time {}", deletion, tsFileResource, timeIndex);
return true;
}

Expand Down Expand Up @@ -2595,10 +2595,8 @@ private void deleteDataDirectlyInFile(List<TsFileResource> tsfileResourceList, M
// The file size may be smaller than the original file, so the increment here may be
// negative
involvedModificationFile.close();
logger.info(
"[Deletion] Deletion with path {} written into mods file:{}.",
modEntry,
involvedModificationFile);
logger.debug(
"[Deletion] Deletion {} written into mods file:{}.", modEntry, involvedModificationFile);
}

// can be deleted by files
Expand Down