Skip to content

Trim port in stop scripts & data dir#15134

Merged
HTHou merged 2 commits intomasterfrom
trim_port_and_dir_in_scripts
Mar 19, 2025
Merged

Trim port in stop scripts & data dir#15134
HTHou merged 2 commits intomasterfrom
trim_port_and_dir_in_scripts

Conversation

@jt2594838
Copy link
Contributor

The scripts of stopping data nodes and config nodes use port from the configuration file but do not trim it,
which may cause a failure of matching the port in config and the port of the node.

The same occurs when datanode-env.sh tries to make the dir for heap dump.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.35%. Comparing base (385d0df) to head (4abcda9).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15134   +/-   ##
=========================================
  Coverage     39.34%   39.35%           
  Complexity      193      193           
=========================================
  Files          4596     4598    +2     
  Lines        295791   295864   +73     
  Branches      36872    36884   +12     
=========================================
+ Hits         116384   116428   +44     
- Misses       179407   179436   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HTHou HTHou merged commit c792db0 into master Mar 19, 2025
52 of 53 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the trim_port_and_dir_in_scripts branch March 20, 2025 07:33
JackieTien97 pushed a commit that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants